Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default css #727

Merged
merged 4 commits into from
Sep 2, 2022
Merged

Default css #727

merged 4 commits into from
Sep 2, 2022

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Sep 2, 2022

Renames CSS to DEFAULT_CSS which sets the low specificity CSS.

Adds CSS with regular specificity to just App

This is because it is tempting to set CSS on App to knock up a quick app, but the results are sometimes surprising because you have to take in to account the specificity of all the widgets.

I still want to push external CSS which offers a number of benefits, but this seems like a reasonable convenience.

Fixes #688

@willmcgugan willmcgugan merged commit 0a66fed into css Sep 2, 2022
@willmcgugan willmcgugan deleted the default-css branch September 2, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants