text-align CSS support
#704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
darrenburns
commented
Aug 25, 2022
•
darrenburns
commented
darrenburns
commented
Aug 25, 2022
|
|
||
| rich_style = self.rich_style | ||
| if isinstance(renderable, Text): | ||
| renderable.stylize(rich_style) | ||
| if not renderable.justify: |
There was a problem hiding this comment.
Wasn't sure whether to do this if or not...
darrenburns
changed the title
text-align CSS support
darrenburns
commented
Aug 26, 2022
Comment on lines
+1595
to
+1597
| "start": "left", | ||
| "end": "right", | ||
| "justify": "full", |
There was a problem hiding this comment.
Since Textual doesn't support RTL, we can just directly map start -> left and so on.
darrenburns
commented
Aug 26, 2022
tests/test_auto_refresh.py
Outdated
| @@ -25,4 +25,4 @@ def test_auto_refresh(): | |||
| elapsed = app.run(quit_after=1, headless=True) | |||
| assert elapsed is not None | |||
| # CI can run slower, so we need to give this a bit of margin | |||
| assert elapsed >= 0.3 and elapsed < 0.6 | |||
| assert 0.3 <= elapsed < 0.8 | |||
There was a problem hiding this comment.
Got some failures where elapsed was outwith the range.
willmcgugan
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.