Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs scrollbar gutter #695

Merged
merged 4 commits into from
Aug 19, 2022
Merged

Docs scrollbar gutter #695

merged 4 commits into from
Aug 19, 2022

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Aug 18, 2022

No description provided.

@@ -0,0 +1,34 @@
# Scrollbar gutter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a Syntax section. See the docs-intro branch for examples...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Syntax section, with a child Values section.

The Values section is probably where we'd link off to "types" e.g. color, scalar, etc.

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the Values section. Will add a task to review existing styles.

Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I added a Syntax section to the styles in the docs-intro branch. Could you please add something similar to scrollbar gutter.


=== "Output"

```{.textual path="docs/examples/styles/scrollbar_gutter.py"}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely love this plugin

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is kind of magical!

Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,34 @@
# Scrollbar gutter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the Values section. Will add a task to review existing styles.


=== "Output"

```{.textual path="docs/examples/styles/scrollbar_gutter.py"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is kind of magical!

@darrenburns darrenburns merged commit 9eea01f into css Aug 19, 2022
@darrenburns darrenburns deleted the docs-scrollbar-gutter branch August 19, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants