Add remove #653
Merged
Add remove #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
willmcgugan
commented
Aug 6, 2022
| @@ -856,7 +856,7 @@ def _register_child(self, parent: DOMNode, child: DOMNode) -> bool: | |||
| return True | |||
| return False | |||
|
|
|||
| def register( | |||
| def _register( | |||
There was a problem hiding this comment.
Devs should never need to call this directly.
There are probably a number of other methods that should be private. Will be an ongoing process to identify them
willmcgugan
commented
Aug 6, 2022
| @@ -36,14 +37,16 @@ def __init__( | |||
| self, | |||
| node: DOMNode | None = None, | |||
| selector: str | None = None, | |||
| nodes: list[DOMNode] | None = None, | |||
| nodes: list[Widget] | None = None, | |||
There was a problem hiding this comment.
Queries now return Widgets rather than DOMNodes. This means that it excludes App, which is find since it is a special object that doesn't have any visuals. Although you can still reference App in a selector.
darrenburns
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a
remove()method to remove a widget from the DOM.