Color harmony #619
Merged
Color harmony #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
commented
Jul 21, 2022
| system="#5a4599", | ||
| dark_surface="#292929", | ||
| ) | ||
| DEFAULT_COLORS = { |
There was a problem hiding this comment.
This structure probably isn't going to survive very long. The colors will eventually be set via the configuration system.
darrenburns
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a tweak to the color system, and fixes for bugs I encountered along the way.
I removed the "system" color for scrollbars, replacing it with the "primary" color. I tinted the scroll track and the "panel" color with the primary color which I think creates a more harmonious look.
I've also separated the light and dark themes in to individual objects, to make it easier to load from configuration.