Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render enhancements #606

Merged
merged 11 commits into from
Jul 12, 2022
Merged

Render enhancements #606

merged 11 commits into from
Jul 12, 2022

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Jul 10, 2022 •
edited
Loading

Started out as tweaks to the buttons, but fixed rendering issues I found along the way

  • Tweaked colors and buttons
  • Added option to refresh children when refreshing a style.
  • Fixed issue with background colors on borders not refreshing when animated
  • Fixed incorrectly applied width: auto
  • Fixed issue where underline was incorrectly applied to padding

Screenshot 2022-07-10 at 15 34 11

@willmcgugan willmcgugan marked this pull request as draft July 10, 2022 07:47
@willmcgugan willmcgugan marked this pull request as ready for review July 10, 2022 14:42
@willmcgugan willmcgugan requested a review from darrenburns July 10, 2022 14:47
darrenburns
darrenburns approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@darrenburns darrenburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willmcgugan willmcgugan merged commit 254dbd6 into css Jul 12, 2022
@willmcgugan willmcgugan deleted the render-enhancements branch July 12, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenburns darrenburns darrenburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willmcgugan @darrenburns