Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(option list): fix render cache option indexing #5478

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(option list): fix render cache option indexing #5478

wants to merge 2 commits into from
+186 −2

Conversation

TomJGooding
Copy link
Contributor

@TomJGooding TomJGooding commented Jan 16, 2025 •
edited
Loading

Fixes #5431

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@TomJGooding
Copy link
Contributor Author

I'm fairly confident this is the correct fix (and all tests pass!), but there's a few moving parts in the OptionList rendering so please let me know if I've missed something!

@TomJGooding TomJGooding marked this pull request as ready for review January 16, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating a OptionList that contains separator lines can result in a garbled display (since 0.86.0)
1 participant
@TomJGooding