Widget focus keybindings #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenburns
changed the title
olivierphi
reviewed
May 27, 2022
willmcgugan
approved these changes
May 27, 2022
Co-authored-by: Olivier Philippon <[email protected]>
willmcgugan
pushed a commit
that referenced
this pull request
May 29, 2022
* Support binding widget focus to keypress, fix focus-within * Update src/textual/app.py Co-authored-by: Olivier Philippon <[email protected]> Co-authored-by: Olivier Philippon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can create a keybinding to immediately focus a widget based on the widget ID. For example:
This will focus the widget with the ID
widget1when you press1on your keyboard.Here's an example video showing how we can use the keyboard to quickly shift our focus across multiple widgets:
keybind-focus.mov
This demo is available in
sandbox/focus_keybindings.py.This PR also fixes an issue with descendant_focus, although the approach is quite inefficient.
I would like to write an integration test for this, but it depends on some of the in-flux stuff inside #543, so I will wait til that is merged before doing so.
Closes #504