Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input selection #5340

Merged
merged 34 commits into from
Dec 6, 2024
Merged

Input selection #5340

merged 34 commits into from
Dec 6, 2024

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Dec 4, 2024 •
edited
Loading

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@darrenburns
Initial machinery for text selection in Input widget
f029383
@darrenburns
Demoting cursor_position to property
24cad3c
@darrenburns
Update validator and watcher to work with Input.selection instead of …
a1cefa5 
…Input.cursor_position
@darrenburns
Click and drag to select
9c8cfcb
@darrenburns
Remove input selection foreground
e376a4e
@darrenburns
Select left and right words
f01bcc8
@darrenburns
Use line API
e1bf6ff
@darrenburns
Remove more unused reactives
bd39e0f
@darrenburns
Fixes
0e0ca7c
@darrenburns
Fix accidental multiple cursors
02c67bf
@darrenburns
Fix MaskedInput
64adf92
@darrenburns
Fix scrolling with double width characters
5c45656
@darrenburns
Update snapshots, remove old tests
f540622
@darrenburns
Snapshot tests for Input
8dc81ac
@darrenburns
Creating new snapshots
c72d85f
@darrenburns
Simplifying implementations
ff54125
@darrenburns
More simplification
1788ca8
@darrenburns
Simplify delete_word_left
5aa06c2
@darrenburns
Apply Input.restrict to all edits
c3339df
@darrenburns
Ensure interaction between selections and insertions (paste and inser…
7a7e553 
…t) is correct
@darrenburns
Add shift+home and shift+end bindings to Input
a949717
@darrenburns
Testing Input.replace and Input.delete
9212b80
@darrenburns
Create new snapshot
c1d871d
@darrenburns
Import annotations from __future__
4972463
@darrenburns darrenburns marked this pull request as ready for review December 5, 2024 17:07
willmcgugan
willmcgugan approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some trivial things.

src/textual/widgets/_input.py Show resolved Hide resolved
tests/input/test_input.py Outdated Show resolved Hide resolved
@willmcgugan willmcgugan merged commit 146eab0 into main Dec 6, 2024
23 checks passed
@willmcgugan willmcgugan deleted the input-selection branch December 6, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darrenburns @willmcgugan