Auto dimensions #527
Auto dimensions #527
Conversation
| def arrange( | ||
| self, parent: Widget, size: Size, scroll: Offset | ||
| ) -> tuple[list[WidgetPlacement], set[Widget]]: | ||
| def arrange(self, parent: Widget, size: Size) -> ArrangeResult: |
There was a problem hiding this comment.
Dropped scroll parameter which wasn't used. Added a type alias for the return type.
| for task in self._child_tasks: | ||
| task.cancel() | ||
| await task | ||
| self._child_tasks.clear() | ||
| if self._task is not None: |
There was a problem hiding this comment.
Could be worth doing this only if the task is not done yet? 🙂 i.e.
if self._task is not None and not self._task.done():There was a problem hiding this comment.
Probably not much point, if the task is done, awaiting it is essentially a no-op.
| @@ -59,7 +59,7 @@ def get_auto_height(container: Size, parent: Size) -> int: | |||
| box_model = get_box_model( | |||
| styles, Size(60, 20), Size(80, 24), get_auto_width, get_auto_height | |||
| ) | |||
| assert box_model == BoxModel(Size(60, 20), Spacing(1, 2, 3, 4)) | |||
| assert box_model == BoxModel(Size(54, 16), Spacing(1, 2, 3, 4)) | |||
There was a problem hiding this comment.
Just to be sure that I understand this correctly... The returned box model now shrinks the available space of a widget according to its margin, right? 🙂
| except Exception: | ||
| pass | ||
| except Exception as error: | ||
| self.on_exception(error) |
There was a problem hiding this comment.
There was a bunch of errors related to log getting called after the App has shutdown, which were previously hidden.
| for task in self._child_tasks: | ||
| task.cancel() | ||
| await task | ||
| self._child_tasks.clear() | ||
| if self._task is not None: |
There was a problem hiding this comment.
Probably not much point, if the task is done, awaiting it is essentially a no-op.
| @@ -59,7 +59,7 @@ def get_auto_height(container: Size, parent: Size) -> int: | |||
| box_model = get_box_model( | |||
| styles, Size(60, 20), Size(80, 24), get_auto_width, get_auto_height | |||
| ) | |||
| assert box_model == BoxModel(Size(60, 20), Spacing(1, 2, 3, 4)) | |||
| assert box_model == BoxModel(Size(54, 16), Spacing(1, 2, 3, 4)) | |||
There's a lack of tests here for the box model / layout system here. Please let that slide just now. I have a feeling there will be more changes required, and I don't yet have a good enough understanding of the various CSS rule interactions.