Optimize Compositor by combining updates #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
willmcgugan
commented
May 10, 2022
willmcgugan
commented
- Deferred rendering of widget updates. When a widget update is request, Textual will wait for 50ms for further updates.
- The compositor can now render multiple updates in a single render.
willmcgugan
commented
May 11, 2022
| @@ -116,6 +136,43 @@ def __init__(self) -> None: | |||
| # The points in each line where the line bisects the left and right edges of the widget | |||
| self._cuts: list[list[int]] | None = None | |||
|
|
|||
| @classmethod | |||
There was a problem hiding this comment.
Adapted from @darrenburns 's region_groups.py
willmcgugan
changed the title
olivierphi
approved these changes
May 11, 2022
There was a problem hiding this comment.
These geometrical and time-based batching operations are far too clever for my little brain 🧠 (especially with the quite little knowledge I have of the Textual internals at the moment), so I can only comment on things that really don't matter, like typos in comments - sorry 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.