Added scroll_to_widget #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
commented
May 6, 2022
src/textual/_compositor.py
Outdated
| @@ -52,17 +52,17 @@ class ReflowResult(NamedTuple): | |||
| resized: set[Widget] # Widgets that have been resized | |||
|
|
|||
|
|
|||
| class RenderRegion(NamedTuple): | |||
| class RegionGeometry(NamedTuple): | |||
There was a problem hiding this comment.
A better name...
olivierphi
approved these changes
May 10, 2022
|
Yeah, that would be great. Hard to unit test some of that logic. |
darrenburns
reviewed
May 10, 2022
Co-authored-by: Darren Burns <[email protected]>
darrenburns
reviewed
May 10, 2022
| return self.scroll_to( | ||
| x=self.scroll_target_x + self.container_size.width, animate=animate | ||
| ) | ||
|
|
||
| def scroll_to_widget(self, widget: Widget, *, animate: bool = True) -> bool: |
There was a problem hiding this comment.
If a widget is taller than the container, and you scroll up to it, it scrolls such that the bottom of the widget aligns with the bottom of the container (and the top of the widget is out of view). I suspect we want the top of the widget to be in view.
darrenburns
reviewed
May 10, 2022
|
Good point. It should be a fixed time. |
|
I've exposed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scroll_to_widgetmethod which scrolls a container to make a widget visible.RenderRegiontoMapGeometrywhich is more descriptive.