DataTable navigation updates #4633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenburns
commented
Jun 11, 2024
Comment on lines
+219
to
+228
| Binding("up,k", "cursor_up", "Cursor Up", show=False), | ||
| Binding("down,j", "cursor_down", "Cursor Down", show=False), | ||
| Binding("right,l", "cursor_right", "Cursor Right", show=False), | ||
| Binding("left,h", "cursor_left", "Cursor Left", show=False), | ||
| Binding("pageup", "page_up", "Page Up", show=False), | ||
| Binding("pagedown", "page_down", "Page Down", show=False), | ||
| Binding("g", "scroll_top", "Top", show=False), | ||
| Binding("G", "scroll_bottom", "Bottom", show=False), | ||
| Binding("home", "scroll_home", "Home", show=False), | ||
| Binding("end", "scroll_end", "End", show=False), |
There was a problem hiding this comment.
Added some common bindings, particularly for horizontal navigation which I found to be lacking when using the keyboard.
darrenburns
commented
Jun 11, 2024
Comment on lines
+50
to
+51
| Binding("ctrl+pageup", "page_left", "Page Left", show=False), | ||
| Binding("ctrl+pagedown", "page_right", "Page Right", show=False), |
There was a problem hiding this comment.
Horizontally navigating widgets can be a bit slow when using the keyboard.
If you hold ctrl and use the scroll wheel, it applies it in the horizontal direction. So, I thought maybe we could have that apply to pageup/pagedown too.
darrenburns
commented
Jun 11, 2024
Comment on lines
+2567
to
+2583
| def action_scroll_home(self) -> None: | ||
| """Move the cursor and scroll to the leftmost column.""" | ||
| self._set_hover_cursor(False) | ||
| cursor_type = self.cursor_type | ||
| if self.show_cursor and (cursor_type == "cell" or cursor_type == "column"): | ||
| self.move_cursor(column=0) | ||
| else: | ||
| self.scroll_x = 0 | ||
|
|
||
| def action_scroll_end(self) -> None: | ||
| """Move the cursor and scroll to the rightmost column.""" | ||
| self._set_hover_cursor(False) | ||
| cursor_type = self.cursor_type | ||
| if self.show_cursor and (cursor_type == "cell" or cursor_type == "column"): | ||
| self.move_cursor(column=len(self.columns) - 1) | ||
| else: | ||
| self.scroll_x = self.max_scroll_x |
There was a problem hiding this comment.
Quickly jumping to the first/last cell in a row. Also intended to improve horizontal navigation with the keyboard.
darrenburns
changed the title
willmcgugan
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the pageup/pagedown behaviour in the DataTable to match the TextArea widget (and Google Sheets!).
Adds some extra bindings to DataTable, particularly around horizontal navigation.