Fix TextArea holding on to focus when hidden while doing a mouse selection
#4295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigogiraoserrao
approved these changes
Mar 14, 2024
Comment on lines
+1508
to
+1512
| async def _on_mouse_up(self, event: events.MouseUp) -> None: | ||
| """Finalize the selection that has been made using the mouse.""" | ||
| self._end_mouse_selection() | ||
|
|
||
| async def _on_hide(self, event: events.Hide) -> None: |
There was a problem hiding this comment.
These two should definitely be in reverse order. 🙄
There was a problem hiding this comment.
I just did that to be annoying. :-P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered by @TomJGooding and similar to #4274 -- if a
TextAreawas in a mouse selection state and theTextAreawas hidden, the selection didn't get ended and so the mouse remained captured by the (now hidden)TextArea.Fixes #4292.