Fix content size cache #4211
Merged
Fix content size cache #4211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenburns
approved these changes
Feb 26, 2024
|
@willmcgugan I feel like I am missing something. The video below shows that at widths 81 & 82 I have the big green region that I shouldn't. Screen.Recording.2024-02-26.at.14.55.26.movI ran this app with the 0.52.1 release (prior to your PR) and the behaviour seems to be exactly the same. |
|
(With #4217 merged, a fuller test can be written. I was going to write it myself but as per my comment above, it looks like the original issue hasn't been solved.) |
|
Looks like another issue. Only occurs when there is a gutter on the grid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4179
Forgive the lack of a test. The code is covered. But it could use #4212 for a fuller test.