Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map ANSI colours #4192

Merged
merged 18 commits into from
Feb 27, 2024
Merged

Map ANSI colours #4192

merged 18 commits into from
Feb 27, 2024

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Feb 20, 2024 •
edited
Loading

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@darrenburns darrenburns linked an issue Feb 20, 2024 that may be closed by this pull request
Expose ANSI themes #4119
Closed
@darrenburns darrenburns marked this pull request as ready for review February 20, 2024 15:10
willmcgugan
willmcgugan requested changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a request.

src/textual/_ansi_theme.py Outdated Show resolved Hide resolved
@darrenburns
Copy link
Member Author

darrenburns commented Feb 22, 2024 •
edited
Loading

Resolved the two pending requests, and put in place a workaround for failing command palette snapshot tests which were causing frequent failures. Still not really sure why it's required. If an App has been instantiated anywhere in the test session before the command palette snapshot tests run, they produce slightly different output and therefore fail. So running those tests in isolation without also running the unit tests causes failures...

willmcgugan
willmcgugan requested changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a thought about caching and themes.

src/textual/filter.py Outdated Show resolved Hide resolved
willmcgugan
willmcgugan approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one request

src/textual/app.py Show resolved Hide resolved
@darrenburns darrenburns merged commit 363c9d4 into main Feb 27, 2024
20 checks passed
@darrenburns darrenburns deleted the ansi-color-mapping branch February 27, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose ANSI themes
2 participants
@darrenburns @willmcgugan