fix(text area): update code editor constructor #4172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the `TextArea.code_editor` convenience constructor to include the new `read_only` and `max_checkpoints` attributes.
|
When I added this constructor I thought to myself "I'm definitely gonna forget to update this..." 😂 I wonder if we could add a sort of "meta" test which would catch variance between the constructors using the |
|
I've added a test in 4cb6244 - hopefully I've understood you correctly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
TextArea.code_editorconvenience constructor to include the newread_onlyandmax_checkpointsattributes.Please review the following checklist.