fix for showing scrollbars #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## css #416 +/- ##
==========================================
+ Coverage 38.06% 46.15% +8.09%
==========================================
Files 85 96 +11
Lines 6526 7982 +1456
==========================================
+ Hits 2484 3684 +1200
- Misses 4042 4298 +256
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
willmcgugan
commented
Apr 25, 2022
| @@ -253,7 +253,7 @@ def log( | |||
| key_values = " ".join( | |||
| f"{key}={value}" for key, value in kwargs.items() | |||
| ) | |||
| output = " ".join((output, key_values)) | |||
| output = f"{output} {key_values}" if output else key_values | |||
There was a problem hiding this comment.
Previously logs had an extra space if you only used keywords args.
darrenburns
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for scrollbars not being enabled on first refresh.
The issue was that scrollbars weren't enabled prior to changing the sizes.