Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Widget.lock attribute. #4139

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Adds Widget.lock attribute. #4139

merged 3 commits into from
Feb 19, 2024

Conversation

rodrigogiraoserrao
Copy link
Contributor

Adds an asyncio.Lock to every widget.

Fixes #4134.

@rodrigogiraoserrao rodrigogiraoserrao marked this pull request as ready for review February 8, 2024 11:56
willmcgugan
willmcgugan requested changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Don't merge just yet.

@rodrigogiraoserrao rodrigogiraoserrao mentioned this pull request Feb 19, 2024
Merged
@rodrigogiraoserrao rodrigogiraoserrao merged commit ba17dfb into main Feb 19, 2024
20 checks passed
@rodrigogiraoserrao rodrigogiraoserrao deleted the add-widget-lock branch February 19, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

@davep davep Awaiting requested review from davep

@darrenburns darrenburns Awaiting requested review from darrenburns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a lock to every widget.
2 participants
@rodrigogiraoserrao @willmcgugan