Directory tree reload now preserves state #4123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigogiraoserrao
force-pushed
the
directory-tree-reload
branch
from
abca7bd to
43f15d8
Compare
willmcgugan
requested changes
Feb 6, 2024
Address review feedback by handling the error of trying to load a directory that doesn't exist instead of checking if it exists. Review comment: https://github.com/Textualize/textual/pull/4123\#discussion_r1479504901
willmcgugan
approved these changes
Feb 7, 2024
|
@rodrigogiraoserrao @willmcgugan That's awesome, thanks for this! |
|
All credit to Rodrigo. |
This was referenced Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4056.
Adds an
asyncio.LocktoTree.Adds a private coroutine
DirectoryTree._reloadused byDirectoryTree.reload/.reload_nodethat reloads a subtree and preserves expanded nodes + highlighted node.Fixes #4122.
While working on the above I noticed this bug and I fixed it en passant.