Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test and remove dead code #3514

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Add a test and remove dead code #3514

merged 2 commits into from
Oct 23, 2023

Conversation

rodrigogiraoserrao
Copy link
Contributor

No description provided.

MouseScrollUp and MouseScrollDown inherit from MouseEvent so this branch is never taken.
@@ -976,17 +976,6 @@ def _forward_event(self, event: events.Event) -> None:
else:
widget._forward_event(event._apply_offset(-region.x, -region.y))

elif isinstance(event, (events.MouseScrollDown, events.MouseScrollUp)):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MouseScrollUp and MouseScrollDown inherit from MouseEvent so this branch is never taken.
(See the branch immediately before.)

Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@willmcgugan willmcgugan merged commit 2ccc063 into main Oct 23, 2023
@willmcgugan willmcgugan deleted the screen-tests branch October 23, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants