Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stringify the cast type, for <3.10 support #351

Merged
merged 2 commits into from
Apr 6, 2022

Conversation

tusharsadhwani
Copy link
Contributor

Since the types here are an argument, we need to manually stringify them to avoid causing runtime errors.

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #351 (54b72f5) into css (386aa6d) will increase coverage by 3.63%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##              css     #351      +/-   ##
==========================================
+ Coverage   38.06%   41.70%   +3.63%     
==========================================
  Files          85       86       +1     
  Lines        6526     7014     +488     
==========================================
+ Hits         2484     2925     +441     
- Misses       4042     4089      +47     
Flag Coverage Δ
unittests 41.70% <40.00%> (+3.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/textual/_event_broker.py 0.00% <ø> (ø)
src/textual/_timer.py 50.00% <ø> (+17.14%) ⬆️
src/textual/_types.py 78.94% <ø> (ø)
src/textual/app.py 0.00% <0.00%> (ø)
src/textual/css/tokenizer.py 89.01% <ø> (-0.12%) ⬇️
src/textual/drivers/linux_driver.py 0.00% <0.00%> (ø)
src/textual/layouts/grid.py 21.42% <ø> (-8.04%) ⬇️
src/textual/renderables/blank.py 0.00% <0.00%> (ø)
src/textual/scrollbar.py 0.00% <0.00%> (ø)
src/textual/views/_dock_view.py 0.00% <0.00%> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80bad9b...54b72f5. Read the comment docs.

@willmcgugan
Copy link
Collaborator

Thanks

@willmcgugan willmcgugan merged commit e243718 into Textualize:css Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants