Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(listview): add method to append multiple items #3012

Conversation

TomJGooding
Copy link
Contributor

@TomJGooding TomJGooding commented Jul 25, 2023

Closes #2997 by adding a ListView.extend method to append multiple items. This is essentially a cut-and-paste from the existing append method!

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@TomJGooding TomJGooding marked this pull request as ready for review July 25, 2023 17:49
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darrenburns darrenburns merged commit eccb6e5 into Textualize:main Aug 21, 2023
@TomJGooding
Copy link
Contributor Author

TomJGooding commented Aug 21, 2023

Thanks! Looks like the changelog has become a bit out of sync, do you want me to submit new PR or will you do this housekeeping before the next release?

[EDIT: Created a quick PR to correct this.]

@TomJGooding TomJGooding deleted the feat-listview-add-method-to-append-multiple-items branch August 21, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListView method to append many
3 participants