Fix a crash caused by a prompt being wider than a SelectionList
#2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 19, 2023
willmcgugan
approved these changes
Jul 19, 2023
src/textual/widgets/_option_list.py
Outdated
| add_span = self._spans.append | ||
| option_ids = self._option_ids | ||
| add_lines = self._lines.extend | ||
|
|
||
| # Adjust the options for our purposes. | ||
| options = self.app.console.options.copy().update_width( |
There was a problem hiding this comment.
update_width does a copy() internally, so you won't need the explicit copy.
There was a problem hiding this comment.
Ahh hah! That explains why it wasn't there before!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue raised in #2900 (and also #2969).
The PR adds a
wrapproperty toOptionList(Trueby default), which tells the widget if it should auto-wrap prompts (which it was anyway and which was the source of the issue withSelectionList). When set toFalse, any prompt that is wider than the widget will be truncated, with ellipsis.This is then set to
FalseforSelectionList. Whereas before aSelectionListwith over-long prompts would result in the crash in the related issue, it will now look like this: