Layout Resolver enhancement #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
commented
Feb 18, 2022
willmcgugan
commented
Feb 18, 2022
| @@ -72,9 +76,8 @@ def layout_resolve(total: int, edges: Sequence[Edge]) -> List[int]: | |||
| # to the following line | |||
| remainder = _Fraction(0) | |||
| for index, edge in flexible_edges: | |||
| size, remainder = divmod(portion * edge.fraction + remainder, 1) | |||
| sizes[index] = size | |||
| sizes[index], remainder = divmod(portion * edge.fraction + remainder, 1) | |||
There was a problem hiding this comment.
I like how this loop turned out..
Codecov Report
@@ Coverage Diff @@
## css #295 +/- ##
==========================================
+ Coverage 38.06% 40.15% +2.09%
==========================================
Files 85 88 +3
Lines 6526 6806 +280
==========================================
+ Hits 2484 2733 +249
- Misses 4042 4073 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
darrenburns
reviewed
Feb 21, 2022
| @@ -72,9 +76,8 @@ def layout_resolve(total: int, edges: Sequence[Edge]) -> List[int]: | |||
| # to the following line | |||
| remainder = _Fraction(0) | |||
| for index, edge in flexible_edges: | |||
| size, remainder = divmod(portion * edge.fraction + remainder, 1) | |||
| sizes[index] = size | |||
| sizes[index], remainder = divmod(portion * edge.fraction + remainder, 1) | |||
Co-authored-by: Darren Burns <[email protected]>
darrenburns
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can see
layout_resolvebecoming fairly critical, since it solves a common class of problem we will no doubt see a lot. I've optimized it a little, and added tests.