-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Toggle Buttons on a selection list #2930
Conversation
This PR makes the Toggle Buttons on a selection list clickable/hoverable by adding the style meta option property |
Good catch. Would you mind adding a CHANGELOG entry to that effect too? I sense we should also add an extra unit test or two to ensure that clicking on the checkbox has the desired effect (I'm happy to help with that if you're not familiar with adding tests to Textual). |
As I’m not familiar with adding tests, I’d appreciate getting help on doing that |
Thanks.
No worries; when I get a moment I'll add an appropriate test for this. |
Mainly updating the now-external snapshot testing code so that the failure report (which was to be expected) gets generated.
Added an update of the dependencies to this PR as Textualize/pytest-textual-snapshot#1 was needed so that snapshot tests could be run and an error report generated; the change here (correctly) caused snapshot tests to fail as there's new metadata kicking around. Also then regenerated the snapshot tests. |
Right, that all looks like it's going through okay; I'll see about adding the extra test in the morning. Thanks again for this @dmunozv04 -- good spot! |
Tests added; as I've added code to this too I've requested review from the rest of the team. |
Please review the following checklist.