Expose animation callback in scroll methods #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
reviewed
Jul 12, 2023
| @@ -1760,6 +1765,9 @@ def _scroll_to( | |||
| self.scroll_target_y = self.scroll_y = y | |||
| scrolled_y = scroll_y != self.scroll_y | |||
|
|
|||
| if on_complete is not None: | |||
There was a problem hiding this comment.
I think you will need self.call_after_refresh(on_complete) here which will allow coroutines to be used, and will ensure the update is called after the screen has updated.
There was a problem hiding this comment.
fixed! Thanks for going through it.
willmcgugan
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the following checklist.
Allows using callbacks after the end of the animation (or end of scrolling) in
scrollmethods inWidgetclass via theon_complete=keyword argument.This is my first PR to this project, so I will need some help with any contribution protocol or additional modifications that might be required.
Thanks for the great tool!