DataTable key lookup enhancements (Closes #2586, Closes #2587) #2876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ze#2586) Added DataTable.get_cell_coordinate Added DataTable.get_row_index (Textualize#2587) Added DataTable.get_column_index
|
@darrenburns Would you mind having a look at this one when you have a moment |
|
Thanks @trav-c ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to resolve row and column keys to their current index values:
DataTable.get_cell_coordinate(row_key, column_key) -> CoordinateDataTable.get_row_index(row_key) -> int(No way to get an index fromDataTable's row key #2587)DataTable.get_column_index(column_key) -> intDataTable.get_cell(row_key, column_key)type hints to accept string keys as per the existing behavior of other methods such asDataTable.update_cell(DataTable.get_cellshould accept strings as keys #2586)Please review the following checklist.