Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure _options attribute is assigned in Select constructor #2690

Merged
merged 3 commits into from
May 31, 2023
Merged

Ensure _options attribute is assigned in Select constructor #2690

merged 3 commits into from
May 31, 2023

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented May 30, 2023 •
edited
Loading

Fixes #2662.

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@darrenburns darrenburns marked this pull request as ready for review May 30, 2023 12:16
@willmcgugan willmcgugan merged commit 0dc58bd into main May 31, 2023
@willmcgugan willmcgugan deleted the select-crash-fix branch May 31, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting Select.value in on_mount for a Select in a container raises an exception
2 participants
@darrenburns @willmcgugan