Refactor Message.control and Tree Messages #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronst
changed the title
|
Looks good to me. @davep thoughts? |
|
@willmcgugan Aye, I like what I see here! |
willmcgugan
requested changes
May 22, 2023
davep
reviewed
May 22, 2023
Added! |
This was
linked to
issues
May 24, 2023
|
I believe this should also fix #2648. |
|
THanks @aaronst ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to address #2528 and #2529 as suggested by @davep.
Message.controlto a propertytreeparameter from:Tree.NodeCollapsedTree.NodeExpandedTree.NodeHighlightedTree.NodeSelectedDirectoryTree.FileSelectedcontrolto returnself.node.tree.I was not entirely following what changes needed to be made to the
@ondecorator, but I believe the rest is there. Additionally, I was getting a type error forDirectoryTree.FileSelected.controlbecauseself.node.treeis aTree[DirEntry]vs aDirectoryTree. Not sure if that matters so I wanted to raise it here.Hope this helps, happy to get it finished with a little more guidance.