Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable support in CSS #258

Merged
merged 22 commits into from
Feb 7, 2022
Merged

Variable support in CSS #258

merged 22 commits into from
Feb 7, 2022

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Feb 3, 2022 •
edited
Loading

Allows users to use variables in CSS files. See dev_sandbox.scss for some examples.

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (css@06417bb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             css     #258   +/-   ##
======================================
  Coverage       ?   38.06%           
======================================
  Files          ?       85           
  Lines          ?     6526           
  Branches       ?        0           
======================================
  Hits           ?     2484           
  Misses         ?     4042           
  Partials       ?        0
Flag Coverage Δ
unittests 38.06% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06417bb...386aa6d. Read the comment docs.

@darrenburns darrenburns marked this pull request as ready for review February 4, 2022 11:44
willmcgugan
willmcgugan requested changes Feb 7, 2022
View reviewed changes
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Didn't need to run it, think I grok it after your explanation. Just a few requests.

src/textual/css/_styles_builder.py Outdated Show resolved Hide resolved
src/textual/css/tokenizer.py Outdated Show resolved Hide resolved
src/textual/css/parse.py Outdated Show resolved Hide resolved
src/textual/css/parse.py Outdated Show resolved Hide resolved
src/textual/css/parse.py Outdated Show resolved Hide resolved
src/textual/css/parse.py Show resolved Hide resolved
willmcgugan
willmcgugan approved these changes Feb 7, 2022
View reviewed changes
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willmcgugan willmcgugan merged commit 12bfe8c into css Feb 7, 2022
@willmcgugan willmcgugan deleted the css-variables-substitution branch February 7, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darrenburns @codecov-commenter @willmcgugan