Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clearing an OptionList #2567

Merged
merged 5 commits into from
May 16, 2023
Merged

Fix clearing an OptionList #2567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aff9bcd
Fix clearing an OptionList
davep May 15, 2023
f12aeb0
Remove forced content tracking refresh in clear_options
davep May 16, 2023
32fa259
Add a TODO comment to the effect that this is a temp fix
davep May 16, 2023
3d2e3d9
Add a snapshot test for a rebuilt Select
davep May 16, 2023
1ebfe2f
Update the snapshits
davep May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/textual/widgets/_option_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,11 +627,17 @@ def clear_options(self) -> Self:
"""
self._contents.clear()
self._options.clear()
self._refresh_content_tracking(force=True)
self.highlighted = None
self._mouse_hovering_over = None
self.virtual_size = Size(self.scrollable_content_region.width, 0)
self.refresh()
# TODO: See https://github.com/Textualize/textual/issues/2582 -- it
# should not be necessary to do this like this here; ideally here in
# clear_options it would be a forced refresh, and also in a
# `on_show` it would be the same (which, I think, would actually
# solve the problem we're seeing). But, until such a time as we get
# to the bottom of 2582... this seems to delay the refresh enough
# that things fall into place.
self._request_content_tracking_refresh()
return self

def _set_option_disabled(self, index: int, disabled: bool) -> Self:
Expand Down
Loading