Add the ability to remove nodes from a Tree
#2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for removing an individual node, via the node. Note that attempting to remove the root node of a Tree is an error and will case TreeNode.RemoveRootError to be raised. See Textualize#2462.
Up until now there wasn't really a way for the tree to go empty, outside of clear/reset. Now that we can remove nodes on the fly, that is possible. This takes that into account. See Textualize#2462.
Sometimes the user may wish to delete a given node, other times it might be a requirement to just remove the children (this will be especially useful for Textualize#2448 where we'll want to keep the directory entry itself, but remove and recreate its contents). See Textualize#2462.
willmcgugan
approved these changes
May 8, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two methods of removing nodes from a
Tree, bother methods being on the nodes themselves (to matchTreeNode.addandTreeNode.add_leaf. They are:TreeNode.remove_children-- removes any children of the node, but leaves the node itself intact.TreeNode.remove-- removes the node and any of its children.Note that any attempt to remove the
Tree.rootwill result in an exception being raised because the TextualTreealways expects to have a root.As a convenience (used by this PR but not the point of this PR) this also adds
TreeNode.is_root.