Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokenise CSS variables #250

Merged
merged 10 commits into from
Feb 2, 2022
Merged

Tokenise CSS variables #250

merged 10 commits into from
Feb 2, 2022

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Feb 1, 2022

Implements tokenisation of SASS-like variables.

Variables can be declared with values at the root scope, and you can refer to these variables inside any rule or variable declaration.

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (css@092dd56). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             css     #250   +/-   ##
======================================
  Coverage       ?   37.74%           
======================================
  Files          ?       84           
  Lines          ?     6449           
  Branches       ?        0           
======================================
  Hits           ?     2434           
  Misses         ?     4015           
  Partials       ?        0           
Flag Coverage Δ
unittests 37.74% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 092dd56...ac81229. Read the comment docs.

@darrenburns darrenburns changed the title [WIP] Tokenise CSS variables Tokenise CSS variables Feb 1, 2022
@darrenburns darrenburns linked an issue Feb 1, 2022 that may be closed by this pull request
@darrenburns darrenburns marked this pull request as ready for review February 1, 2022 13:51
@darrenburns
Copy link
Member Author

@willmcgugan have modified the tokenisation as agreed

Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. And well tested!

@darrenburns darrenburns merged commit 19b835b into css Feb 2, 2022
@darrenburns darrenburns deleted the css-variables-tokenise branch February 2, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tokenize CSS variables
3 participants