Fix the drawing of Tree lines in respect to things being selected
#2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than always start at the root, the code should start at the beginning of the path. See Textualize#2397.
Redux. I managed to commit the wrong thing last time; although it was using this and this was done for that.
rodrigogiraoserrao
approved these changes
May 4, 2023
|
|
||
| ### Changed | ||
|
|
||
| - The DataTable cursor is now scrolled into view when the cursor coordinate is changed programmatically https://github.com/Textualize/textual/issues/2459 | ||
| - run_worker exclusive parameter is now `False` by default https://github.com/Textualize/textual/pull/2470 | ||
| - Added `always_update` as an optional argument for `reactive.var` |
There was a problem hiding this comment.
😆 isn't an "Added" line a feature that was added?
There was a problem hiding this comment.
Normally yes but really this just changes the behaviour of var rather than adds something new. Felt a bit grand to have it in the added section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two distinct but overlapping issues with the drawing of lines with
Tree.show_root=Trueand the root node was selected.Treewas first draw or first received focus.To aid with the latter issue
reactive.varhas acquired analways_updateparameter.See #2397.