Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underline bar renderable #246

Merged
merged 6 commits into from
Jan 31, 2022
Merged

Underline bar renderable #246

merged 6 commits into from
Jan 31, 2022

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Jan 31, 2022

Naming is hard :) more than happy to hear suggestions for the params etc.

Closes #238

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2022

Codecov Report

❗ No coverage uploaded for pull request base (css@3574a6d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             css     #246   +/-   ##
======================================
  Coverage       ?   38.58%           
======================================
  Files          ?       82           
  Lines          ?     6240           
  Branches       ?        0           
======================================
  Hits           ?     2408           
  Misses         ?     3832           
  Partials       ?        0           
Flag Coverage Δ
unittests 38.58% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3574a6d...65eb1b0. Read the comment docs.

@darrenburns darrenburns linked an issue Jan 31, 2022 that may be closed by this pull request
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@willmcgugan willmcgugan merged commit 9e55d4c into css Jan 31, 2022
@willmcgugan willmcgugan deleted the tab-underline branch January 31, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a bar renderable for tabbed dialogs
3 participants