Have Container *not* show scrollbars by default
#2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per Textualize#2361 this removes default scrollbars on Container (and so adds them on ScrollableContainer).
In connection with Textualize#2361.
In connection with Textualize#2361.
rodrigogiraoserrao
approved these changes
Apr 24, 2023
willmcgugan
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to satisfy #2361, having
Containerhide scrollbars by default, encouraging the use ofScrollableContainer(and of courseHorizontalScrollandVerticalScroll) when that's a requirement. It also updatesHorizontalScrollandVerticalScrollto hide the opposing scrollbar by default.All affected tests are updated too.
The tutorial has been updated to use
ScrollableContainerinstead ofContainer.NOTE: As reflected by the need to change tests, this is a breaking change (albeit one that likely won't affect too many applications).