Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal layout #235

Merged
merged 8 commits into from
Feb 4, 2022
Merged

Horizontal layout #235

merged 8 commits into from
Feb 4, 2022

Conversation

darrenburns
Copy link
Member

No description provided.

@darrenburns darrenburns changed the base branch from css to vertical-layout January 27, 2022 13:41
@darrenburns darrenburns changed the base branch from vertical-layout to css January 27, 2022 13:42
@darrenburns darrenburns changed the base branch from css to vertical-layout January 27, 2022 13:52
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2022

Codecov Report

Merging #235 (5430048) into css (e2ee2aa) will increase coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              css     #235      +/-   ##
==========================================
+ Coverage   37.27%   37.31%   +0.03%     
==========================================
  Files          84       85       +1     
  Lines        6409     6435      +26     
==========================================
+ Hits         2389     2401      +12     
- Misses       4020     4034      +14     
Flag Coverage Δ
unittests 37.31% <50.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/textual/layouts/horizontal.py 44.00% <44.00%> (ø)
src/textual/layouts/factory.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2ee2aa...5430048. Read the comment docs.

Base automatically changed from vertical-layout to css February 4, 2022 11:50
src/textual/layout.py Show resolved Hide resolved
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willmcgugan willmcgugan merged commit 06417bb into css Feb 4, 2022
@willmcgugan willmcgugan deleted the horizontal-layout branch February 4, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants