Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical layout #234

Merged
merged 6 commits into from
Feb 4, 2022
Merged

Vertical layout #234

merged 6 commits into from
Feb 4, 2022

Conversation

darrenburns
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #234 (d1738cf) into css (cea331e) will decrease coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              css     #234      +/-   ##
==========================================
- Coverage   38.14%   38.14%   -0.01%     
==========================================
  Files          81       81              
  Lines        6202     6189      -13     
==========================================
- Hits         2366     2361       -5     
+ Misses       3836     3828       -8     
Flag Coverage Δ
unittests 38.14% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/textual/app.py 0.00% <0.00%> (ø)
src/textual/layout.py 31.46% <ø> (ø)
src/textual/reactive.py 33.75% <ø> (-0.82%) ⬇️
src/textual/view.py 34.13% <ø> (-0.40%) ⬇️
src/textual/layouts/vertical.py 47.05% <25.00%> (+2.32%) ⬆️
src/textual/widget.py 50.23% <100.00%> (+0.46%) ⬆️
src/textual/css/stylesheet.py 50.49% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea331e...d1738cf. Read the comment docs.

@darrenburns darrenburns linked an issue Jan 27, 2022 that may be closed by this pull request
@willmcgugan
Copy link
Collaborator

LGTM

@willmcgugan willmcgugan merged commit 1dfee08 into css Feb 4, 2022
@willmcgugan willmcgugan deleted the vertical-layout branch February 4, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS Vertical Layout
3 participants