Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure an app's CSS refresh updates all screens in the stack #2339

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

davep
Copy link
Contributor

@davep davep commented Apr 20, 2023

Mainly to address #1999 (dark mode toggles in a "child" screen not updating the "parent" screen). In turn also fixes what happens when making CSS changes in a situation where the frontmost screen has a transparent background.

@davep davep self-assigned this Apr 20, 2023
@davep davep added bug Something isn't working Task labels Apr 20, 2023
@davep davep marked this pull request as ready for review April 20, 2023 10:51
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@davep davep merged commit 60542c5 into Textualize:main Apr 20, 2023
@davep davep deleted the refresh-all-the-screens branch April 20, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode toggle in a stacked screen doesn't cause mode switch in other screens
3 participants