Prevent reactive-watcher loop in Tabs / TabbedContent. #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigogiraoserrao
changed the title
Labels are cheaper to use and the final visual result of the test won't depend on the directory it runs from.
Turns out I didn't need a descriptor. :(
Comment on lines
123
to
124
| if not active: | ||
| raise ValueError("'active' tab must not be empty string.") |
There was a problem hiding this comment.
Originally I just let the setter set the attribute active on the child Tabs but the tests failed because they expected a ValueError when setting the tab to an empty string, so I added it back in 6eb141c.
However, to me it doesn't make much sense that I can't set TabbedContent.active = "" but I can set Tabs.active = "".
Am I "right"? If so, do we allow active = "" everywhere or nowhere?
There was a problem hiding this comment.
@willmcgugan pinging you because you already merged but this was left unresolved.
There was a problem hiding this comment.
I don't think an active tab of empty string doesn't anything useful, so it probably should be an error in both places.
willmcgugan
approved these changes
Apr 18, 2023
willmcgugan
added a commit
that referenced
this pull request
Apr 18, 2023
This reverts commit 66a6448.
willmcgugan
added a commit
that referenced
this pull request
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #2229.
See this comment wherein for an explanation of the issue.
We use a descriptor to proxy the attribute
activefromTabstoTabbedContentwithout having to keep it in sync in two different places.