Add scroll_to_center method. #2255
Merged
+309
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
reviewed
Apr 11, 2023
| @@ -406,3 +406,13 @@ def test_fr_margins(snap_compare): | |||
| def test_scroll_visible(snap_compare): | |||
| # https://github.com/Textualize/textual/issues/2181 | |||
| assert snap_compare(SNAPSHOT_APPS_DIR / "scroll_visible.py", press=["t"]) | |||
|
|
|||
|
|
|||
| def test_scroll_to_center(snap_compare): | |||
There was a problem hiding this comment.
If this test is expected to fail, can you mark is as an xfail ?
There was a problem hiding this comment.
This test is not expected to fail now. It will fail eventually, when the bug is fixed.
willmcgugan
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #2031.