Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for viewport units, remove DataTable max-height #2247

Merged
merged 6 commits into from
Apr 10, 2023
Merged

Fix for viewport units, remove DataTable max-height #2247

merged 6 commits into from
Apr 10, 2023

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Apr 10, 2023 •
edited
Loading

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@darrenburns darrenburns changed the title Add viewport units snapshot test Fix for viewport units, update DataTable to max-height 100% Apr 10, 2023
@darrenburns darrenburns changed the title Fix for viewport units, update DataTable to max-height 100% Fix for viewport units, remove DataTable max-height Apr 10, 2023
@darrenburns darrenburns marked this pull request as ready for review April 10, 2023 15:07
@darrenburns darrenburns merged commit 40cc2db into main Apr 10, 2023
@darrenburns darrenburns deleted the datatable-vh-fix branch April 10, 2023 15:13
@bphunter1972 bphunter1972 mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darrenburns @willmcgugan