Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worker API #2182

Merged
merged 49 commits into from
Apr 4, 2023
Merged

Worker API #2182

merged 49 commits into from
Apr 4, 2023

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Mar 30, 2023 •
edited
Loading

  • Adds a Worker API
  • Adds Worker API docs
  • Makes Markdown.update non-async
  • Adds release blog post
  • Makes post_message thread safe

@willmcgugan willmcgugan marked this pull request as draft March 30, 2023 16:59
@willmcgugan willmcgugan marked this pull request as ready for review April 3, 2023 21:01
davep
davep approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@davep davep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo-squishing suggestions and stuff, and a question or two; looks pretty damn powerful!

docs/blog/posts/release0-18-0.md Outdated Show resolved Hide resolved
docs/blog/posts/release0-18-0.md Show resolved Hide resolved
docs/guide/workers.md Outdated Show resolved Hide resolved
docs/guide/workers.md Outdated Show resolved Hide resolved
docs/guide/workers.md Outdated Show resolved Hide resolved
docs/guide/workers.md Show resolved Hide resolved
src/textual/_animator.py Outdated Show resolved Hide resolved
src/textual/_work_decorator.py Outdated Show resolved Hide resolved
src/textual/_worker_manager.py Outdated Show resolved Hide resolved
src/textual/worker.py Show resolved Hide resolved
@willmcgugan willmcgugan changed the title WIP Worker API Worker API Apr 4, 2023
rodrigogiraoserrao
rodrigogiraoserrao approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, some questions, and some suggestions, but no show-stoppers for me.
Although I recommend committing at least the typo fixes before merging.

CHANGELOG.md Outdated Show resolved Hide resolved
docs/blog/posts/release0-18-0.md Outdated Show resolved Hide resolved
docs/blog/posts/release0-18-0.md Outdated Show resolved Hide resolved
docs/blog/posts/release0-18-0.md Outdated Show resolved Hide resolved
docs/guide/workers.md Outdated Show resolved Hide resolved
src/textual/worker.py Outdated Show resolved Hide resolved
src/textual/worker.py Outdated Show resolved Hide resolved
src/textual/worker.py Outdated Show resolved Hide resolved
src/textual/worker.py Show resolved Hide resolved
tests/test_work_decorator.py Show resolved Hide resolved
@willmcgugan willmcgugan merged commit b5689b1 into main Apr 4, 2023
@willmcgugan willmcgugan deleted the worker-api branch April 4, 2023 12:12
@rodrigogiraoserrao rodrigogiraoserrao mentioned this pull request Apr 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigogiraoserrao rodrigogiraoserrao rodrigogiraoserrao approved these changes

@davep davep davep approved these changes

@darrenburns darrenburns Awaiting requested review from darrenburns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willmcgugan @davep @rodrigogiraoserrao