fix border issue #2074
Merged
fix border issue #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
commented
Mar 15, 2023
| @@ -1,43 +1,40 @@ | |||
| from textual.app import App, ComposeResult | |||
| from textual.containers import Grid | |||
| from textual.widget import Widget | |||
| from textual.containers import Vertical | |||
There was a problem hiding this comment.
Rewrote this snapshot test, because it wasn't clear to me what it should look like.
There was a problem hiding this comment.
The problem I see with the rewrite is that it doesn't exercise the CSS parser in quite the same way. The original test was designed to try out a good combination of styles, colours and alpha values to ensure it all worked together.
That looks to have been lost.
There was a problem hiding this comment.
True. But those are better captured with a unit test. Snapshots should be used to validate that things look correct only, where you can't tell from the data alone.
rodrigogiraoserrao
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where a border was partially black. I'd seen this before but it was a mystery why until recently...
You can see the issue in this snapshot. Note the inner, tall, and wide borders.
Also changed the test for border opacity, which also exhibited the error. Note how the border was black with 0% opacity, where it should have been invisible.