Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add app to active message pump #2071

Merged
merged 4 commits into from
Mar 16, 2023
Merged

add app to active message pump #2071

merged 4 commits into from
Mar 16, 2023

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Mar 15, 2023 •
edited
Loading

Fixes #2070

The sender wasn't being set correctly when posting to app.

I've also dropped sender from messages entirely. I think it is more likely to be a source of confusion.

@willmcgugan willmcgugan marked this pull request as draft March 15, 2023 16:05
@willmcgugan willmcgugan marked this pull request as ready for review March 16, 2023 11:11
rodrigogiraoserrao
rodrigogiraoserrao approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for this! 🚀

@willmcgugan willmcgugan merged commit a404ee5 into main Mar 16, 2023
@willmcgugan willmcgugan deleted the sender-fix branch March 16, 2023 11:26
@renovate renovate bot mentioned this pull request Sep 15, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigogiraoserrao rodrigogiraoserrao rodrigogiraoserrao approved these changes

@davep davep Awaiting requested review from davep

@darrenburns darrenburns Awaiting requested review from darrenburns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Message '.sender' set to last composed widget
2 participants
@willmcgugan @rodrigogiraoserrao