Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add containers #2030

Merged
merged 20 commits into from
Mar 15, 2023
Merged

Add containers #2030

merged 20 commits into from
Mar 15, 2023

Conversation

rodrigogiraoserrao
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao commented Mar 13, 2023 •
edited
Loading

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@rodrigogiraoserrao rodrigogiraoserrao linked an issue Mar 13, 2023 that may be closed by this pull request
Additional containers #1957
Closed
@rodrigogiraoserrao
Make docs comply with new containers.
0e51520
@rodrigogiraoserrao
Tweak default Center/Middle dimensions.
429c8a3 
We set dimensions to 1fr instead of 100% (original request) or blank (previous change) for consistency with the other containers.
@rodrigogiraoserrao
Merge branch 'main' into add-containers
cc8f652
@rodrigogiraoserrao
Update snapshot tests.
3518d38
@rodrigogiraoserrao rodrigogiraoserrao marked this pull request as ready for review March 13, 2023 12:03
@rodrigogiraoserrao rodrigogiraoserrao mentioned this pull request Mar 13, 2023
Open
davep
davep approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@davep davep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some docstring phrasing issues from me, but I don't see anything that's a blocker.

src/textual/containers.py Outdated Show resolved Hide resolved
src/textual/containers.py Outdated Show resolved Hide resolved
src/textual/containers.py Outdated Show resolved Hide resolved
willmcgugan
willmcgugan reviewed Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good. Just a few quibbles.

docs/examples/widgets/button.css Outdated Show resolved Hide resolved
src/textual/containers.py Outdated Show resolved Hide resolved
src/textual/containers.py Outdated Show resolved Hide resolved
willmcgugan
willmcgugan approved these changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Would you mind looking through all the examples, python -m textual, textual colors, etc.

Just to confirm scrolling behaviour hasn't broken.

If everything is working, feel free to merge.

@rodrigogiraoserrao
Copy link
Contributor Author

Looks good!

Would you mind looking through all the examples, python -m textual, textual colors, etc.

Just to confirm scrolling behaviour hasn't broken.

If everything is working, feel free to merge.

Everything looking good. 🚀

@rodrigogiraoserrao rodrigogiraoserrao merged commit 1246934 into main Mar 15, 2023
@rodrigogiraoserrao rodrigogiraoserrao deleted the add-containers branch March 15, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

@davep davep davep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional containers
3 participants
@rodrigogiraoserrao @davep @willmcgugan