tabs widget #2020
Merged
tabs widget #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+228
to
+236
| del tabs[active_index] | ||
| try: | ||
| return tabs[active_index] | ||
| except IndexError: | ||
| try: | ||
| return tabs[active_index - 1] | ||
| except IndexError: | ||
| pass | ||
| return None |
There was a problem hiding this comment.
There is something I don't get. Can't we just do this by inspecting the length of tabs with respect to the active_index?
Why do we have to del tabs[active_index] and whatnot?
Does del tabs[active_index] do anything other than deleting that specific entry from the list tabs?
There was a problem hiding this comment.
I'm sure there is a more elegant solution. But we want to get the next active tab, which is normally the one to the right. Unless we're at the end, then its the one to the left.
Co-authored-by: Rodrigo Girão Serrão <[email protected]>
Co-authored-by: Rodrigo Girão Serrão <[email protected]>
Co-authored-by: Rodrigo Girão Serrão <[email protected]>
Co-authored-by: Rodrigo Girão Serrão <[email protected]>
Co-authored-by: Rodrigo Girão Serrão <[email protected]>
Co-authored-by: Rodrigo Girão Serrão <[email protected]>
davep
approved these changes
Mar 13, 2023
Co-authored-by: Rodrigo Girão Serrão <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Tabs widget.
This will form part of a larger
TabbedContentwidget, but could be used independently.Screen.Recording.2023-03-13.at.11.21.32.mov