Drop explicit sender attribute from messages #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll review properly tomorrow morning, if this doesn't go in beforehand, but much like with the alternate compose method I'm throwing a very hearty OH HELL YES at this. |
davep
reviewed
Mar 5, 2023
davep
approved these changes
Mar 6, 2023
src/textual/widgets/_radio_set.py
Outdated
| self.post_message_no_wait( | ||
| self.Changed(self, cast(RadioButton, event.input)) | ||
| ) | ||
| self.post_message(self.Changed(self, cast(RadioButton, event.radio_button))) |
There was a problem hiding this comment.
I suspect we don't need this cast now.
| super().__init__(sender) | ||
| self.input = sender | ||
| super().__init__() | ||
| self._toggle_button = toggle_button | ||
| """A reference to the toggle button that was changed.""" |
| """A reference to the toggle button that was changed.""" | ||
| self.value = value | ||
| """The value of the toggle button after the change.""" | ||
|
|
||
| @property | ||
| def control(self) -> ToggleButton: | ||
| """Alias for self.toggle_button.""" |
There was a problem hiding this comment.
This will need a reword given that toggle_button was moved to being "private". Actually, I'm wondering if control should move to the two individual child message classes.
willmcgugan
pushed a commit
that referenced
this pull request
Mar 6, 2023
davetapley
added a commit
to JEFuller/textual-select
that referenced
this pull request
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rectifies two API issues.
The
senderattribute create boiler plate when sending messages. It was also a source of confusion as to its purpose.Having two messages
post_messageandpost_message_no_waitis rather ugly, and difficult to explain. Awaiting posting something on a message queue is only necessary if the queue is bounded, but they aren't any more.senderfrom the Message base class.post_message. There is now justpost_messagewhich is syncronous.controlalias to messages from controls.See CHANGELOG for details