Explicitly type attribute sender in messages.
#1922
Conversation
rodrigogiraoserrao
changed the title
sender in messages.
There was a problem hiding this comment.
After some thought, I don't think we can merge this.
More accurate typing is generally a win, but sender is an internal detail. It just so happens that sender is the thing you interacted with for most widgets, but we don't guarantee that. In the future, maybe something else sends the message. Or we have different child widgets send the event, but we want them to be treated in the same way by a parent. In that case sender may be of different types.
There's also the issue that event.sender.id could be anything, but event.input.id is self documenting.
| @@ -3,7 +3,9 @@ | |||
| import functools | |||
| from dataclasses import dataclass | |||
| from itertools import chain, zip_longest | |||
| from multiprocessing import Event | |||
There was a problem hiding this comment.
If you have some kind of auto-import adder in your IDE. I think you should turn it off. Pretty sure we don't use multiprocessing here.
There was a problem hiding this comment.
I also don't know how this ended up here! 😅
I might have some auto-import thing turned on.
There was a problem hiding this comment.
I might have some auto-import thing turned on.
I think it's part of pylance/pyright; it ha a habit of doing the same thing via eglot in Emacs. Generally it only does the import if you pick an auto-imported completion (in Emacs it's generally easy to see where it's comping from so you can avoid it), and normally I noticed if it's managed to sneak one in when it comes to reviewing the commit in magit (atomic commits for the win here, of course).
What I've yet to find is how to tell pylance/pyright to turn it off. There is apparently a setting (python.analysis.autoImportCompletions) but I've yet to figure out a non-project-specific way of configuring it.
| from operator import itemgetter | ||
| from tkinter import E |
There was a problem hiding this comment.
Definitely don't need this!
There was a problem hiding this comment.
I don't know how this ended up here! 😅
This will fix #1813.
This PR also removes some superfluous event attributes, like
Button.Pressed.buttonorInput.Changed.input.These are noted in the CHANGELOG.
Finally, this PR makes
DataTableevents generics over the same data type as theDataTableitself, akin to howTreedoes it.I typechecked all my changes and I did not introduce new type errors.
(Or rather, I did but I fixed them before opening the PR! 🤪 )